implement malloc_usable_size and enable pool tests for disjoint #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
reviewed
Feb 24, 2025
src/pool/pool_disjoint.c
Outdated
| slab_t *slab = | ||
| (slab_t *)critnib_find_le(disjoint_pool->known_slabs, (uintptr_t)ptr); | ||
| if (slab == NULL || ptr >= slab_get_end(slab)) { | ||
| // regular free |
Contributor
There was a problem hiding this comment.
I think comment is incorrect because of copy-n-paste
bratpiorka
reviewed
Feb 24, 2025
pbalcer
force-pushed
the
malloc-usable-size-disjoint-pool
branch
from
943545a to
585547e
Compare
bratpiorka
approved these changes
Feb 24, 2025
pbalcer
force-pushed
the
malloc-usable-size-disjoint-pool
branch
2 times, most recently
from
71d089d to
7d5a238
Compare
lplewa
requested changes
Feb 24, 2025
pbalcer
force-pushed
the
malloc-usable-size-disjoint-pool
branch
from
7d5a238 to
cbdd3ac
Compare
Contributor
Author
done. |
pbalcer
force-pushed
the
malloc-usable-size-disjoint-pool
branch
10 times, most recently
from
7cc6fdc to
c2f9d5d
Compare
kswiecicki
approved these changes
Feb 25, 2025
pbalcer
force-pushed
the
malloc-usable-size-disjoint-pool
branch
2 times, most recently
from
f90922b to
249c364
Compare
lplewa
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement malloc_usable_size and enable pool tests for disjoint.
Checklist